8313779: RISC-V: use andn / orn in the MD5 instrinsic

[Ilyagavrilin]

Hi all,
This pull request contains a backport of commit 4726960f from the openjdk/jdk repository.

MD5 implementation already backported to jdk21u: 4eafc45

The commit being backported was authored by Antonios Printezis on 7 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8313779 needs maintainer approval

Issue

• JDK-8313779: RISC-V: use andn / orn in the MD5 instrinsic (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/209/head:pull/209
$ git checkout pull/209

Update a local copy of the PR:
$ git checkout pull/209
$ git pull https://git.openjdk.org/jdk21u.git pull/209/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 209

View PR using the GUI difftool:
$ git pr show -t 209

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/209.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back igavrilin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @Ilyagavrilin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (f38f884d)

[Ilyagavrilin]

/approval request I would like to backport this into jdk21u; Applies clean, low-risk, risc-v only change, improves md5 implementation (backported to jdk21u) Testing: tier1/hotspot:tier2 on risc-v board

[openjdk]

@Ilyagavrilin The approval request has been created successfully.

[openjdk]

@Ilyagavrilin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313779: RISC-V: use andn / orn in the MD5 instrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• c1f13ea: 8316514: Better diagnostic header for VtableStub
• 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
• 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
• 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
• 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
• 89103c6: 8317257: RISC-V: llvm build broken
• b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
• ... and 3 more: https://git.openjdk.org/jdk21u/compare/3130e038435e33e9f994245def242a776e780ebc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Ilyagavrilin]

/integrate

[VladimirKempik]

/sponsor

[openjdk]

@Ilyagavrilin
Your change (at version f38f884) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 915892d.
Since your change was applied there have been 13 commits pushed to the master branch:

• c1f13ea: 8316514: Better diagnostic header for VtableStub
• 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
• 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
• 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
• 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
• 89103c6: 8317257: RISC-V: llvm build broken
• b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
• ... and 3 more: https://git.openjdk.org/jdk21u/compare/3130e038435e33e9f994245def242a776e780ebc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@VladimirKempik @Ilyagavrilin Pushed as commit 915892d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.