Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307766: Linux: Provide the option to override the timer slack #21

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 28, 2023

Clean backport of experimental feature for in-field use.

Additional testing:

  • Linux x86_64 fastdebug, new test
  • Linux x86_64 fastdebug, tier1
  • Linux x86_64 fastdebug, tier2
  • Linux x86_64 fastdebug, tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307766: Linux: Provide the option to override the timer slack (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/jdk21u.git pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/21.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7173c3009e0999f13eaa4bee5eedee7326f9d124 8307766: Linux: Provide the option to override the timer slack Jul 28, 2023
@openjdk
Copy link

openjdk bot commented Jul 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307766: Linux: Provide the option to override the timer slack

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 24fe96b: 8309746: Reconfigure check should include make/conf/version-numbers.conf
  • bb234a0: 8311026: Some G1 specific tests do not set -XX:+UseG1GC
  • 75a792b: 8311285: report some fontconfig related environment variables in hs_err file
  • e04b306: 8311249: Remove unused MemAllocator::obj_memory_range
  • ffdf7ac: Merge
  • 817dc55: 8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist
  • aae2cbd: 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock
  • 6786fa4: 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
  • fde53fc: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt
  • 6d9da7c: 8311815: Incorrect exhaustivity computation
  • ... and 56 more: https://git.openjdk.org/jdk21u/compare/e1062802519e3a3073e2973e8d4d86c2e9187740...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good (and low risk in my opinion, for 21).

@shipilev
Copy link
Member Author

shipilev commented Aug 2, 2023

Testing is clean (the remaining GHA failure is unrelated). Reviews are good. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

Going to push as commit 53aceba.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 6f76b65: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • 5c6cd06: Merge
  • 731b2e9: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
  • 0439d58: 8300937: Update nroff pages in JDK 21 before RC
  • bb63b79: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86
  • f242c3b: 8313241: Temporarily disable "malformed control flow" assert to reduce noise
  • 1c875fd: 8313250: Exclude java/foreign/TestByteBuffer.java on AIX
  • 3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
  • a10dbce: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms
  • f666e60: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64
  • ... and 72 more: https://git.openjdk.org/jdk21u/compare/e1062802519e3a3073e2973e8d4d86c2e9187740...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2023
@openjdk openjdk bot closed this Aug 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@shipilev Pushed as commit 53aceba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8307766-timer-slack branch August 24, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants