Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg #210

Closed
wants to merge 1 commit into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Sep 28, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316566 needs maintainer approval

Issue

  • JDK-8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.org/jdk21u.git pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/210.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d154fcd0de0612f58abbc5027f409b9b2eb0dc2 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @robehn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
  • 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
  • 89103c6: 8317257: RISC-V: llvm build broken
  • b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Oct 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit 9ffec67.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
  • 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
  • 89103c6: 8317257: RISC-V: llvm build broken
  • b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@robehn Pushed as commit 9ffec67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn
Copy link
Contributor Author

robehn commented Oct 9, 2023

/backport jdk17u-dev

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@robehn the backport was successfully created on the branch robehn-backport-9ffec67a in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9ffec67a from the openjdk/jdk21u repository.

The commit being backported was authored by Robbin Ehn on 4 Oct 2023 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git robehn-backport-9ffec67a:robehn-backport-9ffec67a
$ git checkout robehn-backport-9ffec67a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git robehn-backport-9ffec67a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant