Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case #214

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 29, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8314883 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.org/jdk21u.git pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/214.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 97b94cb1cdeba00f4bba7326a300c0336950f3ec 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 29, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Sep 29, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Oct 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 643914d.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 9caf6c6: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • bd4e706: 8312612: handle WideCharToMultiByte return values
  • 2184afe: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • f49acbb: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • 667e639: 8316540: StoreReproducibilityTest fails on some locales
  • d9bb3ca: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 66c77d9: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • 834c45c: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • e76be61: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • ... and 14 more: https://git.openjdk.org/jdk21u/compare/b12961d94d71c2a06dc1e44ae9c46aaec817e863...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@MBaesken Pushed as commit 643914d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant