8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163

[voitylov]

Clean backport of JDK-8316879.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316879 needs maintainer approval

Issue

• JDK-8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/216/head:pull/216
$ git checkout pull/216

Update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.org/jdk21u.git pull/216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 216

View PR using the GUI difftool:
$ git pr show -t 216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/216.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @voitylov This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[voitylov]

/approval request allows java.lang.String.RegionMatches1Tests to pass.

[openjdk]

@voitylov The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (a3d80f26)

[openjdk]

@voitylov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[voitylov]

/integrate

[voitylov]

could a Committer sponsor this please? Thank you!

[openjdk]

@voitylov
Your change (at version a3d80f2) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 6a4e492.
Since your change was applied there have been 11 commits pushed to the master branch:

• 915892d: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
• c1f13ea: 8316514: Better diagnostic header for VtableStub
• 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
• 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
• 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
• 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
• bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
• 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
• 89103c6: 8317257: RISC-V: llvm build broken
• ... and 1 more: https://git.openjdk.org/jdk21u/compare/b12961d94d71c2a06dc1e44ae9c46aaec817e863...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @voitylov Pushed as commit 6a4e492.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.