Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" #22

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 28, 2023

Hi all,

This pull request contains a backport of JDK-8308609, commit 44a8aa06 from the openjdk/jdk repository.

The commit being backported was authored by Andrew Haley on 16 Jun 2023 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" (Bug - P3)
  • JDK-8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk21u.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/22.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 44a8aa0691f046d720a789a89c9039a010658f0c 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" Jul 28, 2023
@openjdk
Copy link

openjdk bot commented Jul 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all

Reviewed-by: mbaesken, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 53aceba: 8307766: Linux: Provide the option to override the timer slack
  • 6f76b65: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2023

Webrevs

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Jul 31, 2023
@RealCLanger
Copy link
Contributor Author

/issue add 8310586

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@RealCLanger
Adding additional issue to issue list: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all.

@AlanBateman
Copy link

If this one is integrated then you'll probably need to backport JDK-8311926 too.

@RealCLanger
Copy link
Contributor Author

If this one is integrated then you'll probably need to backport JDK-8311926 too.

Yes, it's on my list. However, I didn't want to squeeze it in here. I'm currently running tests for this PR.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2023
@AlanBateman
Copy link

Yes, it's on my list. However, I didn't want to squeeze it in here. I'm currently running tests for this PR.

Okay, I'm mostly wondering about the change to ProblemList-Virtual.txt to exclude it only on linux-x64, it should be all platforms. There is work required to improve the robustness that will surface when this test is run with JTREG_TEST_THREAD_FACTORY=Virtual, it's not specific to linux-x64. I suspect Dan excluded only on that platform because it was only initially seen on that platform.

Copy link

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport of JDK-8308609 looks fine.

JDK-8310586 excluded in ProblemList-Virtual.txt for linux-x64 only, it should be generic-all.

@RealCLanger
Copy link
Contributor Author

JDK-8311926

Yes, this change is done in the follow-up JDK-8311926. We'll also need JDK-8310211.

@RealCLanger
Copy link
Contributor Author

GHA failures will be fixed with #36 which I'll integrate as well.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

Going to push as commit b0da6c1.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 0346a34: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX
  • 40092ed: 8313428: GHA: Bump GCC versions for July 2023 updates
  • 230df99: 8312591: GCC 6 build failure after JDK-8280982
  • 89875df: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 53aceba: 8307766: Linux: Provide the option to override the timer slack
  • 6f76b65: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2023
@openjdk openjdk bot closed this Aug 4, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 4, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@RealCLanger Pushed as commit b0da6c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants