Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316179: Use consistent naming for lightweight locking in MacroAssembler #220

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 2, 2023

Clean backport to make subsequent backports clean. The risk is low, as it only renames things. There might still be build failures due to missing renames, but that should be easily caught.

Additional testing:

  • macos-aarch64-server-fastdebug, hotspot:tier1

Progress

  • Change must not contain extraneous whitespace
  • JDK-8316179 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316179: Use consistent naming for lightweight locking in MacroAssembler (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/220/head:pull/220
$ git checkout pull/220

Update a local copy of the PR:
$ git checkout pull/220
$ git pull https://git.openjdk.org/jdk21u.git pull/220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 220

View PR using the GUI difftool:
$ git pr show -t 220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/220.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 639ba13c4b0ada1c2ae0a46e99ed707c219b3e53 8316179: Use consistent naming for lightweight locking in MacroAssembler Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Oct 2, 2023

/approval request Provides the ground for clean backports in this area. Applies cleanly. Renames, have a minor risk of breaking the builds, easily detectable, and no reports so far.

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@shipilev The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316179: Use consistent naming for lightweight locking in MacroAssembler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 643914d: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 9caf6c6: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • bd4e706: 8312612: handle WideCharToMultiByte return values
  • 2184afe: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • f49acbb: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • 667e639: 8316540: StoreReproducibilityTest fails on some locales
  • d9bb3ca: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 66c77d9: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • 834c45c: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • ... and 15 more: https://git.openjdk.org/jdk21u/compare/b12961d94d71c2a06dc1e44ae9c46aaec817e863...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 9, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit cbde98c.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 7e1755d: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • 643914d: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 9caf6c6: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • bd4e706: 8312612: handle WideCharToMultiByte return values
  • 2184afe: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • f49acbb: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • 667e639: 8316540: StoreReproducibilityTest fails on some locales
  • d9bb3ca: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 66c77d9: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • ... and 16 more: https://git.openjdk.org/jdk21u/compare/b12961d94d71c2a06dc1e44ae9c46aaec817e863...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@shipilev Pushed as commit cbde98c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8316179-lightweight-names branch October 19, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant