Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316540: StoreReproducibilityTest fails on some locales #221

Closed

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 2, 2023

Backport fixing issue in StoreReproducibilityTest.java causing failure on some locales.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316540 needs maintainer approval

Issue

  • JDK-8316540: StoreReproducibilityTest fails on some locales (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.org/jdk21u.git pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/221.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2023

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7578e8048ee961f22b57ee2b7eed9e9ab783cf5 8316540: StoreReproducibilityTest fails on some locales Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2023

Webrevs

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2023

/approval Fix for issue in StoreReproducibilityTest.java causing failure on some locales. Only modifies test. Clean. GH testing passed.

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@zzambers usage: /approval [<id>] (request|cancel) [<text>]

@zzambers
Copy link
Contributor Author

zzambers commented Oct 2, 2023

/approval request Fix for issue in StoreReproducibilityTest.java causing failure on some locales. Only modifies test. Clean. GH testing passed.

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@zzambers The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316540: StoreReproducibilityTest fails on some locales

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 834c45c: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • e76be61: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 6000176: 8314551: More generic way to handshake GC threads with monitor deflation
  • f455049: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 6a4e492: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
  • 915892d: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • c1f13ea: 8316514: Better diagnostic header for VtableStub
  • 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
  • 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • ... and 9 more: https://git.openjdk.org/jdk21u/compare/3130e038435e33e9f994245def242a776e780ebc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2023
@zzambers
Copy link
Contributor Author

zzambers commented Oct 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@zzambers
Your change (at version 6239690) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Oct 5, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 667e639.
Since your change was applied there have been 22 commits pushed to the master branch:

  • d9bb3ca: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 66c77d9: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • 834c45c: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • e76be61: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 6000176: 8314551: More generic way to handshake GC threads with monitor deflation
  • f455049: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 6a4e492: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
  • 915892d: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • c1f13ea: 8316514: Better diagnostic header for VtableStub
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/3130e038435e33e9f994245def242a776e780ebc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@shipilev @zzambers Pushed as commit 667e639.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants