-
Notifications
You must be signed in to change notification settings - Fork 151
8317257: RISC-V: llvm build broken #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@VladimirKempik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@VladimirKempik Pushed as commit 89103c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport to jdk21u.
It fixes issues with building risc-v port with clang/llvm
Almost clean, one part of original fix wasn't needed in 21u due to missing issue with statis_assert
The fix is pretty trivial, just make a hint to compile which method should be called here, identical to arm64 fix.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/223/head:pull/223
$ git checkout pull/223
Update a local copy of the PR:
$ git checkout pull/223
$ git pull https://git.openjdk.org/jdk21u.git pull/223/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 223
View PR using the GUI difftool:
$ git pr show -t 223
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/223.diff
Webrev
Link to Webrev Comment