Skip to content

8313368: (fc) FileChannel.size returns 0 on block special files #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 4, 2023

Backport of fix for JDK-8313368.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313368 needs maintainer approval

Issue

  • JDK-8313368: (fc) FileChannel.size returns 0 on block special files (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.org/jdk21u.git pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/228.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4ba81f631f572d870d0f2c96fefe0cabc55e1841 8313368: (fc) FileChannel.size returns 0 on block special files Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

⚠️ @bplb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 4, 2023
@bplb
Copy link
Member Author

bplb commented Oct 4, 2023

/approval request

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@bplb
8313368: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Oct 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313368: (fc) FileChannel.size returns 0 on block special files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 643914d: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 9caf6c6: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • bd4e706: 8312612: handle WideCharToMultiByte return values
  • 2184afe: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • f49acbb: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • 667e639: 8316540: StoreReproducibilityTest fails on some locales
  • d9bb3ca: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 66c77d9: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests
  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 9, 2023
@bplb
Copy link
Member Author

bplb commented Oct 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit edc15aa.
Since your change was applied there have been 14 commits pushed to the master branch:

  • e22d333: 8314120: Add tests for FileDescriptor.sync
  • 1bcaff3: 8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs
  • f2cb058: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
  • cbde98c: 8316179: Use consistent naming for lightweight locking in MacroAssembler
  • 7e1755d: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
  • 643914d: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 9caf6c6: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen
  • bd4e706: 8312612: handle WideCharToMultiByte return values
  • 2184afe: 8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out
  • f49acbb: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/834c45ccc63a2abdf8b95cb36fcd42f97022839d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@bplb Pushed as commit edc15aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant