-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8219652: [aix] Tests failing with JNI attach problems. #240
8219652: [aix] Tests failing with JNI attach problems. #240
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8317136,JDK-8317790 |
@RealCLanger Adding additional issue to issue list: |
|
/approval request Requesting backport of the test fix of JDK-8219652 for better test coverage on AIX. I melted two minor exclude list corrections into the main change. Testing: GHA and SAP CI. Risk is low. |
@RealCLanger |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ddc51f2.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit ddc51f2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8219652 from the openjdk/jdk repository.
I also add JDK-8317136 and JDK-8317790 inline which fix a test exclusion.
Other than the additions, the changes apply clean.
Thanks!
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/240/head:pull/240
$ git checkout pull/240
Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jdk21u.git pull/240/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 240
View PR using the GUI difftool:
$ git pr show -t 240
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/240.diff
Webrev
Link to Webrev Comment