Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219652: [aix] Tests failing with JNI attach problems. #240

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 11, 2023

Hi all,

This pull request contains a backport of JDK-8219652 from the openjdk/jdk repository.

I also add JDK-8317136 and JDK-8317790 inline which fix a test exclusion.

Other than the additions, the changes apply clean.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8317790 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8317136 needs maintainer approval
  • JDK-8219652 needs maintainer approval

Issues

  • JDK-8219652: [aix] Tests failing with JNI attach problems. (Bug - P4 - Approved)
  • JDK-8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java (Bug - P4 - Approved)
  • JDK-8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jdk21u.git pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/240.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@RealCLanger RealCLanger changed the title backport 0b0f8b55a6becff269ecf7aa19db12e998e238cd Backport 0b0f8b55a6becff269ecf7aa19db12e998e238cd Oct 11, 2023
@openjdk openjdk bot changed the title Backport 0b0f8b55a6becff269ecf7aa19db12e998e238cd 8219652: [aix] Tests failing with JNI attach problems. Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 11, 2023
@RealCLanger
Copy link
Contributor Author

/issue add JDK-8317136,JDK-8317790

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@RealCLanger
Adding additional issue to issue list: 8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java.

Adding additional issue to issue list: 8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX.

@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@RealCLanger
Copy link
Contributor Author

/approval request Requesting backport of the test fix of JDK-8219652 for better test coverage on AIX. I melted two minor exclude list corrections into the main change. Testing: GHA and SAP CI. Risk is low.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@RealCLanger
8219652: The approval request has been created successfully.
8317136: The approval request has been created successfully.
8317790: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219652: [aix] Tests failing with JNI attach problems.
8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java
8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit ddc51f2.
Since your change was applied there have been 11 commits pushed to the master branch:

  • acbd31b: 8312078: [PPC] JcmdScale.java Failing on AIX
  • 0ce6596: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • d5f2752: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
  • d47d9ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 65941f8: 8312467: relax the builddir check in make/autoconf/basic.m4
  • 1deb1e2: 8317772: NMT: Make peak values available in release builds
  • 252fe46: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 017b78b: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind
  • 3123caa: 8317294: Classloading throws exceptions over already pending exceptions
  • fe29973: 8317736: Stream::handleReset locks twice
  • ... and 1 more: https://git.openjdk.org/jdk21u/compare/7d0a937446d37ef2cd88ebf91b3a429134d447a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@RealCLanger Pushed as commit ddc51f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants