Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind #246

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 12, 2023

Fixes the littering test.

Additional testing:

  • Checked that littering does not happen anymore

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315960 needs maintainer approval

Issue

  • JDK-8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/246/head:pull/246
$ git checkout pull/246

Update a local copy of the PR:
$ git checkout pull/246
$ git pull https://git.openjdk.org/jdk21u.git pull/246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 246

View PR using the GUI difftool:
$ git pr show -t 246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/246.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 373cdf257de78940b2e55e9f5fc38b6233561baf 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023
@shipilev
Copy link
Member Author

/approval request Fixes the littering test. Applies cleanly. Checked that littering does not happen anymore.

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@shipilev
8315960: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 12, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit 017b78b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3123caa: 8317294: Classloading throws exceptions over already pending exceptions
  • fe29973: 8317736: Stream::handleReset locks twice
  • 3a21544: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@shipilev Pushed as commit 017b78b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8315960-test-prefix-suffix branch October 19, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants