Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312395: Improve assertions in growableArray #25

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 31, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312395: Improve assertions in growableArray (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/jdk21u.git pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/25.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b772e67e2929afd9f9d6a4b08713e41f891667c0 8312395: Improve assertions in growableArray Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312395: Improve assertions in growableArray

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Aug 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit d65f1c8.
Since your change was applied there have been 5 commits pushed to the master branch:

  • e9e1520: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose
  • 22e162d: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • f020851: 8311921: Inform about MaxExpectedDataSegmentSize in case of pthread_create failures on AIX
  • 6b738ad: 8311917: MAP_FAILED definition seems to be obsolete in src/java.desktop/unix/native/common/awt/fontpath.c
  • a892672: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@MBaesken Pushed as commit d65f1c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant