Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317987: C2 recompilations cause high memory footprint #251

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 13, 2023

Fix memory footprint issue. Applies cleanly.


Progress

  • JDK-8317987 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317987: C2 recompilations cause high memory footprint (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/251/head:pull/251
$ git checkout pull/251

Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.org/jdk21u.git pull/251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 251

View PR using the GUI difftool:
$ git pr show -t 251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/251.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c88b387881a6e9206f9804b4ca966334c65c008a 8317987: C2 recompilations cause high memory footprint Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

This backport pull request has now been updated with issue from the original commit.

@tstuefe tstuefe marked this pull request as ready for review October 17, 2023 10:46
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317987: C2 recompilations cause high memory footprint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 19, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Oct 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit 0af96a8.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 418a199: 8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux
  • fd329f2: 8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880
  • abfe950: 8317327: Remove JT_JAVA dead code in jib-profiles.js
  • b59b560: 8317818: Combinatorial explosion during 'this' escape analysis
  • c41fc4a: 8316181: Move the fast locking implementation out of the .ad files
  • 876f78e: 8316396: Endless loop in C2 compilation triggered by AddNode::IdealIL
  • 61ec985: 8316735: Print LockStack in hs_err files
  • 055cfe0: 8268916: Tests for AffirmTrust roots
  • dc8603c: 8316958: Add test for unstructured locking
  • 94bb191: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • ... and 28 more: https://git.openjdk.org/jdk21u/compare/7d0a937446d37ef2cd88ebf91b3a429134d447a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@tstuefe Pushed as commit 0af96a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant