Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317336: Assertion error thrown during 'this' escape analysis #252

Closed

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Oct 13, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317336 needs maintainer approval

Issue

  • JDK-8317336: Assertion error thrown during 'this' escape analysis (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/252/head:pull/252
$ git checkout pull/252

Update a local copy of the PR:
$ git checkout pull/252
$ git pull https://git.openjdk.org/jdk21u.git pull/252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 252

View PR using the GUI difftool:
$ git pr show -t 252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/252.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a8473b70797ef8fa0704774bfadbd84cb33a1d53 8317336: Assertion error thrown during 'this' escape analysis Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

⚠️ @archiecobbs This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317336: Assertion error thrown during 'this' escape analysis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@archiecobbs
Copy link
Contributor Author

/approval

@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@archiecobbs usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@archiecobbs
Your change (at version 0c74a15) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 8047100.
Since your change was applied there have been 13 commits pushed to the master branch:

  • a2092fe: 8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX
  • ddc51f2: 8219652: [aix] Tests failing with JNI attach problems.
  • acbd31b: 8312078: [PPC] JcmdScale.java Failing on AIX
  • 0ce6596: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • d5f2752: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
  • d47d9ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 65941f8: 8312467: relax the builddir check in make/autoconf/basic.m4
  • 1deb1e2: 8317772: NMT: Make peak values available in release builds
  • 252fe46: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 017b78b: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind
  • ... and 3 more: https://git.openjdk.org/jdk21u/compare/7d0a937446d37ef2cd88ebf91b3a429134d447a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@shipilev @archiecobbs Pushed as commit 8047100.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants