Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295068: SSLEngine throws NPE parsing CertificateRequests #257

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 16, 2023

Clean backport to handle the SSL corner case.

Additional testing:

  • macos-aarch64-server-fastdebug, jdk_security

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8295068 needs maintainer approval

Issue

  • JDK-8295068: SSLEngine throws NPE parsing CertificateRequests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/257/head:pull/257
$ git checkout pull/257

Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.org/jdk21u.git pull/257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 257

View PR using the GUI difftool:
$ git pr show -t 257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/257.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5667afc36275b064c7700518f453fe8657e13636 8295068: SSLEngine throws NPE parsing CertificateRequests Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to handle the SSL corner case.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@shipilev
8295068: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295068: SSLEngine throws NPE parsing CertificateRequests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 19, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

Going to push as commit 7b4ab28.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2023
@openjdk openjdk bot closed this Oct 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev Pushed as commit 7b4ab28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8295068-ssl-npe branch October 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant