Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880 #258

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 16, 2023

Clean backport to fix a JVM bug, easily reproducible with -UseLSE with LockingMode=2.

Additional testing:

  • macos-aarch64-server-fastdebug build without the fix fails with -UseLSE LockingMode=2, passes with it
  • linux-aarch64-server-fastdebug, tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316880 needs maintainer approval

Issue

  • JDK-8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880 (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/258/head:pull/258
$ git checkout pull/258

Update a local copy of the PR:
$ git checkout pull/258
$ git pull https://git.openjdk.org/jdk21u.git pull/258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 258

View PR using the GUI difftool:
$ git pr show -t 258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/258.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/254 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6a97c078043862b20bd8e1d1b8ccb8699995515 8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880 Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Oct 16, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to fix a JVM bug, easily reproducible with -UseLSE with LockingMode=2.

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@shipilev
8316880: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Oct 17, 2023
@shipilev shipilev changed the base branch from pr/254 to master October 19, 2023 18:43
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

Going to push as commit fd329f2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2023
@openjdk openjdk bot closed this Oct 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev Pushed as commit fd329f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8316880-aarch64-use-lse branch October 19, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants