Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction #26

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 31, 2023

Semi-clean follow-up backport to relax the test.

There are no ProblemList additions in 21u, so this changeset does not have the relevant hunk.

Additional testing:

  • Linux x86_64 fastdebug, affected test

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk21u.git pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/26.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/13 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad34be1f329edc8e7155983835cc70d733c014b8 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Aug 9, 2023

@tstuefe, please ack this?

@shipilev shipilev force-pushed the JDK-8312525-trim-native-test branch from 9009d8e to c5794ab Compare August 9, 2023 16:22
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@shipilev shipilev force-pushed the JDK-8312525-trim-native-test branch from c5794ab to 63f3522 Compare August 10, 2023 11:57
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shipilev shipilev changed the base branch from pr/13 to master August 10, 2023 11:58
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2023
@shipilev
Copy link
Member Author

Push approval is here. Reviews are here. GHA should continue to pass after rebase.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit fc624df.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@shipilev Pushed as commit fc624df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8312525-trim-native-test branch August 24, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants