Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318089: Class space not marked as such with NMT when CDS is off #273

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 20, 2023

Hi all,

this fixes a display problem in NMT, where the class space size is incorrectly shown as "unknown" memory. Its very low-risk.

This pull request contains a backport of commit c0e154c8 from the openjdk/jdk repository.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318089 needs maintainer approval

Issue

  • JDK-8318089: Class space not marked as such with NMT when CDS is off (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/273/head:pull/273
$ git checkout pull/273

Update a local copy of the PR:
$ git checkout pull/273
$ git pull https://git.openjdk.org/jdk21u.git pull/273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 273

View PR using the GUI difftool:
$ git pr show -t 273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/273.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0e154c876e586660b36af6441cd178bc8ebab89 8318089: Class space not marked as such with NMT when CDS is off Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@tstuefe tstuefe marked this pull request as ready for review October 23, 2023 06:16
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318089: Class space not marked as such with NMT when CDS is off

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
  • 5dd22a9: 8317959: Check return values of malloc in native java.base coding
  • e3a2eeb: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
  • bcd73c5: 8310512: Cleanup indentation in jfc files
  • b7e0c4a: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • eb6ea91: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
  • 00698a4: 8317373: Add Telia Root CA v2
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Nov 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

Going to push as commit bb8db71.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 6e21766: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • a96de29: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • 05deef8: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 599b30d: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • de57df4: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • c3c2b9f: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
  • ae5b92c: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • 3e46e29: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 50e1a34: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • bbc5ad7: 8301341: LinkedTransferQueue does not respect timeout for poll()
  • ... and 21 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2023
@openjdk openjdk bot closed this Nov 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@tstuefe Pushed as commit bb8db71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant