Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317692: jcmd GC.heap_dump performance regression after JDK-8292818 #274

Closed

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Oct 20, 2023

Hi all,

This pull request contains a backport of commit 8f5f4407 from the openjdk/jdk repository.

The commit being backported was authored by Hannes Greule on 19 Oct 2023 and was reviewed by Alex Menkov and Frederic Parain.

Thanks!


Progress

  • JDK-8317692 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317692: jcmd GC.heap_dump performance regression after JDK-8292818 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/274/head:pull/274
$ git checkout pull/274

Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.org/jdk21u.git pull/274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 274

View PR using the GUI difftool:
$ git pr show -t 274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/274.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back hgreule! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8f5f44070a7c6dbbbd1005f9d0af5ab7c35179df 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

⚠️ @SirYwell This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 20, 2023
@shipilev
Copy link
Member

Note the test failures. I think we need https://bugs.openjdk.org/browse/JDK-8316778 to be in jdk21u before backporting this one.

@SirYwell
Copy link
Member Author

Note the test failures. I think we need bugs.openjdk.org/browse/JDK-8316778 to be in jdk21u before backporting this one.

I see. Thanks for taking care of that!

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@SirYwell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317692: jcmd GC.heap_dump performance regression after JDK-8292818

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 24, 2023
@shipilev
Copy link
Member

shipilev commented Oct 24, 2023

I see. Thanks for taking care of that!

No problem. I have just pushed that one to jdk21u (9f0d9ca), please merge from master here to get the test run.

@SirYwell
Copy link
Member Author

Tests passed now, I guess we can proceed.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@SirYwell
Your change (at version 7e328f0) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

Going to push as commit c5a6a74.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2023
@openjdk openjdk bot closed this Oct 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@shipilev @SirYwell Pushed as commit c5a6a74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants