Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317920: JDWP-agent sends broken exception event with onthrow option #276

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Oct 20, 2023

Hi all,

This pull request contains a backport of commit 8f4ebd89 from the openjdk/jdk repository.

The commit being backported was authored by Johannes Bechberger on 20 Oct 2023 and was reviewed by Christoph Langer and Chris Plummer.

Thanks!


Progress

  • JDK-8317920 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317920: JDWP-agent sends broken exception event with onthrow option (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/276/head:pull/276
$ git checkout pull/276

Update a local copy of the PR:
$ git checkout pull/276
$ git pull https://git.openjdk.org/jdk21u.git pull/276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 276

View PR using the GUI difftool:
$ git pr show -t 276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/276.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8f4ebd892148f2c23fd11672a10aaf787a0be2eb 8317920: JDWP-agent sends broken exception event with onthrow option Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

⚠️ @parttimenerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317920: JDWP-agent sends broken exception event with onthrow option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 07a1490: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • ... and 33 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@parttimenerd
Your change (at version 7300c43) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit 337271f.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 4cf572e: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • ... and 34 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@GoeLin @parttimenerd Pushed as commit 337271f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the parttimenerd-backport-8f4ebd89 branch November 7, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants