Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317373: Add Telia Root CA v2 #278

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Oct 20, 2023

clean backport to JDK 21u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317373 needs maintainer approval

Issue

  • JDK-8317373: Add Telia Root CA v2 (Enhancement - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/278/head:pull/278
$ git checkout pull/278

Update a local copy of the PR:
$ git checkout pull/278
$ git pull https://git.openjdk.org/jdk21u.git pull/278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 278

View PR using the GUI difftool:
$ git pr show -t 278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/278.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267 8317373: Add Telia Root CA v2 Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Oct 20, 2023

/approval Fix Request jdk21u:
The fix is to add new root CA certificate. The patch applies cleanly and has good test coverage.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@rhalade usage: /approval [<id>] (request|cancel) [<text>]

@rhalade
Copy link
Member Author

rhalade commented Oct 20, 2023

/approval 8317373 request Fix Request jdk21u:,
The fix is to add new root CA certificate. The patch applies cleanly and has good test coverage.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@rhalade
8317373: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317373: Add Telia Root CA v2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 24, 2023
@rhalade
Copy link
Member Author

rhalade commented Oct 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

Going to push as commit 00698a4.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 0fc04fb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
  • 2bf263d: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
  • 9f0d9ca: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
  • 294c19d: 8315088: C2: assert(wq.size() - before == EMPTY_LOOP_SIZE) failed: expect the EMPTY_LOOP_SIZE nodes of this body if empty
  • 2bef0bb: 8315869: UseHeavyMonitors not used

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2023
@openjdk openjdk bot closed this Oct 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@rhalade Pushed as commit 00698a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant