Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310268: RISC-V: misaligned memory access in String.Compare intrinsic #28

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jul 31, 2023

Hi all,

This pull request contains a clean backport of commit d6245b68 from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Kempik on 28 Jul 2023 and was reviewed by Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310268: RISC-V: misaligned memory access in String.Compare intrinsic (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.org/jdk21u.git pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/28.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6245b6832ccd1da04616e8ba4b90321b2551971 8310268: RISC-V: misaligned memory access in String.Compare intrinsic Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310268: RISC-V: misaligned memory access in String.Compare intrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit 89875df.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 53aceba: 8307766: Linux: Provide the option to override the timer slack
  • 6f76b65: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • 5c6cd06: Merge
  • 731b2e9: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
  • 0439d58: 8300937: Update nroff pages in JDK 21 before RC
  • bb63b79: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86
  • f242c3b: 8313241: Temporarily disable "malformed control flow" assert to reduce noise
  • 1c875fd: 8313250: Exclude java/foreign/TestByteBuffer.java on AIX
  • 3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
  • a10dbce: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/24fe96b920801d990363ffcd0d3ebc7599885285...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@VladimirKempik Pushed as commit 89875df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant