Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295555: Primitive wrapper caches could be @Stable #286

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 23, 2023

Clean backport to improve corner case performance around the primitives.

Additional testing:

  • Linux AArch64 server fastdebug, tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8295555 needs maintainer approval

Issue

  • JDK-8295555: Primitive wrapper caches could be @<!---->Stable (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/286/head:pull/286
$ git checkout pull/286

Update a local copy of the PR:
$ git checkout pull/286
$ git pull https://git.openjdk.org/jdk21u.git pull/286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 286

View PR using the GUI difftool:
$ git pr show -t 286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/286.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7de726bd37a2f1fa6f63b601cd2dab1805234e8 8295555: Primitive wrapper caches could be @Stable Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve corner case performance around the primitives.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@shipilev
8295555: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295555: Primitive wrapper caches could be `@Stable`

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
  • 5dd22a9: 8317959: Check return values of malloc in native java.base coding
  • e3a2eeb: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
  • bcd73c5: 8310512: Cleanup indentation in jfc files
  • b7e0c4a: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • eb6ea91: 8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge
  • 00698a4: 8317373: Add Telia Root CA v2
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@shipilev
Copy link
Member Author

shipilev commented Nov 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit 067cd17.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 9405b0c: 8318528: Rename TestUnstructuredLocking test
  • 502d30b: 8318540: make test cannot run .jasm tests directly
  • 1f75ab2: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
  • 5dd22a9: 8317959: Check return values of malloc in native java.base coding
  • e3a2eeb: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
  • bcd73c5: 8310512: Cleanup indentation in jfc files
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@shipilev Pushed as commit 067cd17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8295555-stable-primitive branch November 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant