Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) #289

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 24, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317603 needs maintainer approval

Issue

  • JDK-8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/289/head:pull/289
$ git checkout pull/289

Update a local copy of the PR:
$ git checkout pull/289
$ git pull https://git.openjdk.org/jdk21u.git pull/289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 289

View PR using the GUI difftool:
$ git pr show -t 289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/289.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9b41da9df398ae7e2cf598b2779808d16504e14 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • ... and 57 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 14, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit 81eaed2.
Since your change was applied there have been 77 commits pushed to the master branch:

  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 3515f60: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • daf76eb: 8319339: Internal error on spurious markup in a hybrid snippet
  • be539fd: 8318961: increase javacserver connection timeout values and max retry attempts
  • ccc2fd0: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • 0049afb: 8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations
  • ... and 67 more: https://git.openjdk.org/jdk21u/compare/5121ee686b463291c415e90c96950b4c49183485...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@MBaesken Pushed as commit 81eaed2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant