Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303737: C2: Load can bypass subtype check that enforces it's from the right object type #291

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 25, 2023

Clean backport to fix old C2 bug.

Additional testing:

  • New tests fail without the patch, pass with it
  • Linux aarch64 server fastdebug, tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8303737 needs maintainer approval

Issue

  • JDK-8303737: C2: Load can bypass subtype check that enforces it's from the right object type (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/291/head:pull/291
$ git checkout pull/291

Update a local copy of the PR:
$ git checkout pull/291
$ git pull https://git.openjdk.org/jdk21u.git pull/291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 291

View PR using the GUI difftool:
$ git pr show -t 291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/291.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 52983ed529182901db4e33857bfeab2727e235df 8303737: C2: Load can bypass subtype check that enforces it's from the right object type Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to fix old C2 bug. Applies cleanly. New test fails without the fix and passes with it. tier{1,2,3} tests also pass.

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@shipilev
8303737: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303737: C2: Load can bypass subtype check that enforces it's from the right object type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@shipilev
Copy link
Member Author

shipilev commented Nov 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit c3c2b9f.
Since your change was applied there have been 14 commits pushed to the master branch:

  • ae5b92c: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • 3e46e29: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 50e1a34: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • bbc5ad7: 8301341: LinkedTransferQueue does not respect timeout for poll()
  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a811300: 8314330: java/foreign tests should respect vm flags when start new processes
  • 067cd17: 8295555: Primitive wrapper caches could be @Stable
  • 9405b0c: 8318528: Rename TestUnstructuredLocking test
  • 502d30b: 8318540: make test cannot run .jasm tests directly
  • 1f75ab2: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/5dd22a9bef21140f01c1407162bc4b4cff16e9f2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@shipilev Pushed as commit c3c2b9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8303737-c2-subtype-check branch November 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant