Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException #309

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 31, 2023

I backport this for parity with 17.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8161536 needs maintainer approval

Issue

  • JDK-8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.org/jdk21u.git pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/309.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 939d7c5d8466f9e392beae2947a494ac28695cc1 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 1, 2023

pre submit test failure: ToolTabSnippetTest.testCleaningCompletionTODO(): failure, Known to be shaky, unrelated to this backport.

@openjdk openjdk bot added the approval label Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit a96de29.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 05deef8: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 599b30d: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • de57df4: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • c3c2b9f: 8303737: C2: Load can bypass subtype check that enforces it's from the right object type
  • ae5b92c: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests
  • 3e46e29: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
  • 50e1a34: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests
  • bbc5ad7: 8301341: LinkedTransferQueue does not respect timeout for poll()
  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a811300: 8314330: java/foreign tests should respect vm flags when start new processes
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@GoeLin Pushed as commit a96de29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant