Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318474: Fix memory reporter for thread_count #311

Closed
wants to merge 1 commit into from

Conversation

zer0chance
Copy link
Contributor

@zer0chance zer0chance commented Oct 31, 2023

Clean backport of JDK-8318474


Progress

  • Change must not contain extraneous whitespace
  • JDK-8318474 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318474: Fix memory reporter for thread_count (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/311/head:pull/311
$ git checkout pull/311

Update a local copy of the PR:
$ git checkout pull/311
$ git pull https://git.openjdk.org/jdk21u.git pull/311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 311

View PR using the GUI difftool:
$ git pr show -t 311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/311.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back zer0chance! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0baa9ecd76c9be33a1939e47dcae320bc8b65e96 8318474: Fix memory reporter for thread_count Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

⚠️ @zer0chance This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@zer0chance This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318474: Fix memory reporter for thread_count

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 7091631: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
  • 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 337271f: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 4cf572e: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • ... and 22 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 3, 2023
@zer0chance
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@zer0chance
Your change (at version d73235f) is now ready to be sponsored by a Committer.

@tstuefe
Copy link
Member

tstuefe commented Nov 8, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

Going to push as commit 6bd2c5a.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 7091631: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
  • 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 337271f: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 4cf572e: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • ... and 22 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2023
@openjdk openjdk bot closed this Nov 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@tstuefe @zer0chance Pushed as commit 6bd2c5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants