Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286757: adlc tries to build with /pathmap but without /experimental:deterministic #312

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Nov 1, 2023

Backporting to jdk21u to ensure reproducible Windows natives with -pathmap option.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286757 needs maintainer approval

Issue

  • JDK-8286757: adlc tries to build with /pathmap but without /experimental:deterministic (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.org/jdk21u.git pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/312.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 242eeaea47a259cab4ad2d4f0e055959e9870b8d 8286757: adlc tries to build with /pathmap but without /experimental:deterministic Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

⚠️ @andrew-m-leonard This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@andrew-m-leonard usage: /approval [<id>] (request|cancel) [<text>]

@andrew-m-leonard
Copy link
Author

/approval request Backporting to jdk21u to ensure reproducible Windows natives with -pathmap option that is currently being ignored for adlc due to the missing /experimental:deterministic option.
Low risk, compiler option.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@andrew-m-leonard
8286757: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286757: adlc tries to build with /pathmap but without /experimental:deterministic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 07a1490: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • bb7c86f: 8318415: Adjust describing comment of os_getChildren after 8315026
  • bb8db71: 8318089: Class space not marked as such with NMT when CDS is off
  • 6e21766: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • a96de29: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException
  • 05deef8: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • ... and 13 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 3, 2023
@andrew-m-leonard
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@andrew-m-leonard
Your change (at version 2903ab3) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Nov 3, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

Going to push as commit 504f4a0.
Since your change was applied there have been 25 commits pushed to the master branch:

  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 07a1490: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • bb7c86f: 8318415: Adjust describing comment of os_getChildren after 8315026
  • bb8db71: 8318089: Class space not marked as such with NMT when CDS is off
  • 6e21766: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • ... and 15 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2023
@openjdk openjdk bot closed this Nov 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@shipilev @andrew-m-leonard Pushed as commit 504f4a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andrew-m-leonard
Copy link
Author

/sponsor

Many thanks @shipilev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants