Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317507: C2 compilation fails with "Exceeded _node_regs array" #317

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 1, 2023

Clean backport to fix the C2 crash.

Additional testing:

  • New regression test fails on Linux x86_64 fastdebug without the fix, passes with it
  • Linux x86_64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317507 needs maintainer approval

Issue

  • JDK-8317507: C2 compilation fails with "Exceeded _node_regs array" (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.org/jdk21u.git pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/317.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65 8317507: C2 compilation fails with "Exceeded _node_regs array" Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 2, 2023

/approval request Clean backport to fix the C2 crash. Applies cleanly. Testing passes.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@shipilev
8317507: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317507: C2 compilation fails with "Exceeded _node_regs array"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 337271f: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 4cf572e: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • ... and 9 more: https://git.openjdk.org/jdk21u/compare/de57df40bfc480627e6b8c639ac06150adb89a88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 8, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2023

Going to push as commit c952079.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • 0679922: 8294535: Add screen capture functionality to PassFailJFrame
  • ... and 29 more: https://git.openjdk.org/jdk21u/compare/de57df40bfc480627e6b8c639ac06150adb89a88...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2023
@openjdk openjdk bot closed this Nov 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@shipilev Pushed as commit c952079.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8317507-exceeds-node-array branch November 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant