8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name

[fthevenet]

Hi all,

This pull request contains a backport of commit d96f38b8 from the openjdk/jdk repository.

The commit being backported was authored by Frederic Thevenet on 25 Oct 2023 and was reviewed by Magnus Ihse Bursie and Erik Joelsson.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317510 needs maintainer approval

Issue

• JDK-8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/319/head:pull/319
$ git checkout pull/319

Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.org/jdk21u.git pull/319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 319

View PR using the GUI difftool:
$ git pr show -t 319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/319.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @fthevenet This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (b97b980a)

[openjdk]

@fthevenet This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 7091631: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
• 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
• 337271f: 8317920: JDWP-agent sends broken exception event with onthrow option
• 4cf572e: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
• 4bbea6d: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
• 4a6c0d8: 8314242: Update applications/scimark/Scimark.java to accept VM flags
• 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
• e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
• 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
• 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• ... and 2 more: https://git.openjdk.org/jdk21u/compare/e371a3d92feee932abe1906802df0d5578d9c1ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fthevenet]

/integrate

[openjdk]

@fthevenet
Your change (at version b97b980) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 32987b7.
Since your change was applied there have been 25 commits pushed to the master branch:

• 37888d2: 8314191: C2 compilation fails with "bad AD file"
• 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
• 0e2a520: 8318951: Additional negative value check in JPEG decoding
• 0679922: 8294535: Add screen capture functionality to PassFailJFrame
• 7f02e4a: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
• 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
• b93d884: 8318183: C2: VM may crash after hitting node limit
• fb355df: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
• 50c34ca: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
• ... and 15 more: https://git.openjdk.org/jdk21u/compare/e371a3d92feee932abe1906802df0d5578d9c1ba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @fthevenet Pushed as commit 32987b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.