Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312591: GCC 6 build failure after JDK-8280982 #32

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 2, 2023

Clean backport to upgrade older toolchains.
Risk is low, adds a few warning exclusions.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312591: GCC 6 build failure after JDK-8280982 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.org/jdk21u.git pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/32.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9454b2bbe130fdbe86485b928b80d19156c709ee 8312591: GCC 6 build failure after JDK-8280982 Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312591: GCC 6 build failure after JDK-8280982

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 89875df: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Aug 3, 2023

GHA is not clean due to unrelated infra reasons. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit 230df99.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 89875df: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@shipilev Pushed as commit 230df99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8312591-gcc6-warnings branch August 24, 2023 16:48
theaoqi pushed a commit to loongson/jdk21u that referenced this pull request Jan 10, 2024
30225: remove a Chinese punctuation
30090: [C2] Fix typo for umodL_Reg_Reg instruction
29982: [C2] Add CountedLoopEnd_reg_imm12_short and branchConIU_reg_imm12_short
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant