Skip to content

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"#322

Closed
calvinccheung wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:calvinccheung-backport-9f4a9fe4
Closed

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"#322
calvinccheung wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:calvinccheung-backport-9f4a9fe4

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Nov 3, 2023

Clean backport.

Passed tier1 testing.


Progress

  • JDK-8312434 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/322/head:pull/322
$ git checkout pull/322

Update a local copy of the PR:
$ git checkout pull/322
$ git pull https://git.openjdk.org/jdk21u.git pull/322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 322

View PR using the GUI difftool:
$ git pr show -t 322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/322.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2023

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9f4a9fe488be7ce43f6719c54df25a1fabd8696a 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

⚠️ @calvinccheung This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2023
@calvinccheung
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

Going to push as commit 892938d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2023
@openjdk openjdk bot closed this Nov 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@calvinccheung Pushed as commit 892938d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Nov 3, 2023

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant

Comments