Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315920: C2: "control input must dominate current control" assert failure #324

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 6, 2023

Clean backport to fix another regression.

Additional testing:

  • MacOS AArch64 server fastdebug, new regression test fails without the fix, passes with it
  • Linux AArch64 server fastdebug, tier1 tier2 tier3 tier4

Progress

  • JDK-8315920 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315920: C2: "control input must dominate current control" assert failure (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/324/head:pull/324
$ git checkout pull/324

Update a local copy of the PR:
$ git checkout pull/324
$ git pull https://git.openjdk.org/jdk21u.git pull/324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 324

View PR using the GUI difftool:
$ git pr show -t 324

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/324.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e1e579e8b916191397fc958df32ac3f6003c791 8315920: C2: "control input must dominate current control" assert failure Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 7, 2023

/approval request Clean backport to fix another regression. Applies cleanly. Tests pass.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@shipilev
8315920: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315920: C2: "control input must dominate current control" assert failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • ... and 14 more: https://git.openjdk.org/jdk21u/compare/4bbea6dde3a3b6bf07e515adb3cf7d1b22bfec91...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 14, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit cd4ce01.
Since your change was applied there have been 31 commits pushed to the master branch:

  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 3515f60: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • daf76eb: 8319339: Internal error on spurious markup in a hybrid snippet
  • be539fd: 8318961: increase javacserver connection timeout values and max retry attempts
  • ccc2fd0: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • 0049afb: 8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations
  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • ... and 21 more: https://git.openjdk.org/jdk21u/compare/4bbea6dde3a3b6bf07e515adb3cf7d1b22bfec91...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@shipilev Pushed as commit cd4ce01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8315920-c2-control-dominate branch November 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant