Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library #326

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Nov 6, 2023

Hi all,

This pull request contains a backport of commit [613a3cc6](https://github.com/openjdk/jdk/commit/613a3cc6896ef3c3f836d44de9b2fb05beba6e72) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Renjith Kannath Pariyangad on 31 Oct 2023 and was reviewed by Sergey Bylokhov and Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301846 needs maintainer approval

Issue

  • JDK-8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/326/head:pull/326
$ git checkout pull/326

Update a local copy of the PR:
$ git checkout pull/326
$ git pull https://git.openjdk.org/jdk21u.git pull/326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 326

View PR using the GUI difftool:
$ git pr show -t 326

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/326.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 613a3cc6896ef3c3f836d44de9b2fb05beba6e72 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @Renjithkannath This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@Renjithkannath usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
  • b93d884: 8318183: C2: VM may crash after hitting node limit
  • fb355df: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
  • 50c34ca: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
  • eb8267d: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 31c759d: 8315362: NMT: summary diff reports threads count incorrectly
  • 6bd2c5a: 8318474: Fix memory reporter for thread_count
  • 7091631: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
  • 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • 337271f: 8317920: JDWP-agent sends broken exception event with onthrow option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 8, 2023
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@Renjithkannath
Your change (at version 6988316) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

Going to push as commit 7f02e4a.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
  • 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
  • b93d884: 8318183: C2: VM may crash after hitting node limit
  • fb355df: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
  • 50c34ca: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
  • eb8267d: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 31c759d: 8315362: NMT: summary diff reports threads count incorrectly
  • 6bd2c5a: 8318474: Fix memory reporter for thread_count
  • 7091631: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
  • 421bf8a: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
  • ... and 1 more: https://git.openjdk.org/jdk21u/compare/4cf572e3b99b675418e456e7815fb6fd79245e30...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2023
@openjdk openjdk bot closed this Nov 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@aivanov-jdk @Renjithkannath Pushed as commit 7f02e4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants