8225377: type annotations are not visible to javac plugins across compilation boundaries

[cushon]

Hi,

This is a backport of JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries

The patch applied cleanly, and passes langtools:tier1 tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8225377 needs maintainer approval

Issue

• JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/329/head:pull/329
$ git checkout pull/329

Update a local copy of the PR:
$ git checkout pull/329
$ git pull https://git.openjdk.org/jdk21u.git pull/329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 329

View PR using the GUI difftool:
$ git pr show -t 329

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/329.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (f301bc6d)

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225377: type annotations are not visible to javac plugins across compilation boundaries

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
• 37888d2: 8314191: C2 compilation fails with "bad AD file"
• 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
• 0e2a520: 8318951: Additional negative value check in JPEG decoding
• 0679922: 8294535: Add screen capture functionality to PassFailJFrame
• 7f02e4a: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
• 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
• b93d884: 8318183: C2: VM may crash after hitting node limit
• fb355df: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
• ... and 36 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version f301bc6) is now ready to be sponsored by a Committer.

[shipilev]

@cushon, please enable GHA testing, https://github.com/cushon/jdk21u/actions -- enable the workflows, and then trigger the workflow run against your branch.

[cushon]

@cushon, please enable GHA testing, https://github.com/cushon/jdk21u/actions -- enable the workflows, and then trigger the workflow run against your branch.

Done, thanks

[shipilev]

Done, thanks

Nice, testing passes. I am going to sponsor 21u version, but I think we want to wait a bit for other update releases and see if anything is broken in mainline testing.

/sponsor

[openjdk]

Going to push as commit e00c9bb.
Since your change was applied there have been 49 commits pushed to the master branch:

• b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
• 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
• 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
• 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
• 37888d2: 8314191: C2 compilation fails with "bad AD file"
• 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
• 0e2a520: 8318951: Additional negative value check in JPEG decoding
• 0679922: 8294535: Add screen capture functionality to PassFailJFrame
• 7f02e4a: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
• ... and 39 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @cushon Pushed as commit e00c9bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.