Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308479: [s390x] Implement alternative fast-locking scheme #330

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 7, 2023

Hi all,

This pull request contains a backport of commit 3fe6e0fa from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 26 Sep 2023 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308479 needs maintainer approval

Issue

  • JDK-8308479: [s390x] Implement alternative fast-locking scheme (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/330/head:pull/330
$ git checkout pull/330

Update a local copy of the PR:
$ git checkout pull/330
$ git pull https://git.openjdk.org/jdk21u.git pull/330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 330

View PR using the GUI difftool:
$ git pr show -t 330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/330.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3fe6e0faca78e8106e33a3a53de78f8864be92b7 8308479: [s390x] Implement alternative fast-locking scheme Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308479: [s390x] Implement alternative fast-locking scheme

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • 0679922: 8294535: Add screen capture functionality to PassFailJFrame
  • 7f02e4a: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
  • 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
  • b93d884: 8318183: C2: VM may crash after hitting node limit
  • fb355df: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/4cf572e3b99b675418e456e7815fb6fd79245e30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 9, 2023
@offamitkumar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@offamitkumar
Your change (at version 3c0cde1) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member Author

Hi @TheRealMDoerr , would you please sponsor this PR.

Thanks

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 54fbd4b.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • 0679922: 8294535: Add screen capture functionality to PassFailJFrame
  • 7f02e4a: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • 6632c8a: 8317374: Add Let's Encrypt ISRG Root X2
  • 243142c: 8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before"
  • b93d884: 8318183: C2: VM may crash after hitting node limit
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/4cf572e3b99b675418e456e7815fb6fd79245e30...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@TheRealMDoerr @offamitkumar Pushed as commit 54fbd4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the offamitkumar-backport-3fe6e0fa branch November 9, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants