Skip to content

8312174: missing JVMTI events from vthreads parked during JVMTI attach #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

caoman
Copy link

@caoman caoman commented Nov 8, 2023

This change mitigates JVM crashes and use-after-free bugs in JDK 21. See comments in https://bugs.openjdk.org/browse/JDK-8312174. The patch applies cleanly and passes pre-submit tests.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8312174 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8312174: missing JVMTI events from vthreads parked during JVMTI attach (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/337/head:pull/337
$ git checkout pull/337

Update a local copy of the PR:
$ git checkout pull/337
$ git pull https://git.openjdk.org/jdk21u.git pull/337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 337

View PR using the GUI difftool:
$ git pr show -t 337

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/337.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fda142ff6cfefa12ec1ea4d4eb48b3c1b285bc04 8312174: missing JVMTI events from vthreads parked during JVMTI attach Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

⚠️ @caoman This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312174: missing JVMTI events from vthreads parked during JVMTI attach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 3515f60: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • daf76eb: 8319339: Internal error on spurious markup in a hybrid snippet
  • be539fd: 8318961: increase javacserver connection timeout values and max retry attempts
  • ccc2fd0: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • ... and 24 more: https://git.openjdk.org/jdk21u/compare/4cf572e3b99b675418e456e7815fb6fd79245e30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 14, 2023
@caoman
Copy link
Author

caoman commented Nov 14, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@caoman
Your change (at version 7e3228f) is now ready to be sponsored by a Committer.

@jianglizhou
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit 1ba77d9.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 3515f60: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • daf76eb: 8319339: Internal error on spurious markup in a hybrid snippet
  • be539fd: 8318961: increase javacserver connection timeout values and max retry attempts
  • ccc2fd0: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • ... and 24 more: https://git.openjdk.org/jdk21u/compare/4cf572e3b99b675418e456e7815fb6fd79245e30...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@jianglizhou @caoman Pushed as commit 1ba77d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants