Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312191: ColorConvertOp.filter for the default destination is too slow #347

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 9, 2023

Hi all,

This pull request contains a backport of commit e5f05b5a from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 25 Sep 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312191 needs maintainer approval

Issue

  • JDK-8312191: ColorConvertOp.filter for the default destination is too slow (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/347/head:pull/347
$ git checkout pull/347

Update a local copy of the PR:
$ git checkout pull/347
$ git pull https://git.openjdk.org/jdk21u.git pull/347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 347

View PR using the GUI difftool:
$ git pr show -t 347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/347.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5f05b5a963774914751d9c241dd5693ed06af0b 8312191: ColorConvertOp.filter for the default destination is too slow Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review November 9, 2023 22:32
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Nov 14, 2023

/approval request Performance improvement. Verified by the new test. All jdk_desktop tests are green.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@mrserb
8312191: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312191: ColorConvertOp.filter for the default destination is too slow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/b174d5e18694fa18deaa2f8b63d45ae6974408ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 16, 2023
@mrserb
Copy link
Member Author

mrserb commented Nov 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit d603f8a.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 71eec78: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • fb9bd49: 8317581: [s390x] Multiple test failure with LockingMode=2
  • a25ea4c: 8316719: C2 compilation still fails with "bad AD file"
  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/b174d5e18694fa18deaa2f8b63d45ae6974408ff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@mrserb Pushed as commit d603f8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant