Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316003: Update FileChooserSymLinkTest.java to HTML instructions #353

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Nov 10, 2023

Backports an example of using HTML formatting in PassFailJFrame.

This is a clean backport. It depends on JDK-8294158 being already integrated, see #352.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316003 needs maintainer approval

Issue

  • JDK-8316003: Update FileChooserSymLinkTest.java to HTML instructions (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.org/jdk21u.git pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/353.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c587211bf8c60a7a1f6cc63770c38ede6cb4e173 8316003: Update FileChooserSymLinkTest.java to HTML instructions Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 10, 2023

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Nov 10, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316003: Update FileChooserSymLinkTest.java to HTML instructions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/337271f833972f00a0928e658e9b5d2ebcee67b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 14, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit 8de7b61.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
  • 2545f55: 8317039: Enable specifying the JDK used to run jtreg
  • 321ba68: 8313643: Update HarfBuzz to 8.2.2
  • ffa87b5: 8318240: [AIX] Cleaners.java test failure
  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions
  • cb352c2: 8318759: Add four DigiCert root certificates
  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • ... and 40 more: https://git.openjdk.org/jdk21u/compare/337271f833972f00a0928e658e9b5d2ebcee67b6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@aivanov-jdk Pushed as commit 8de7b61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant