Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86 #355

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 13, 2023

Clean backport to improve generated code density.

Additional testing:

  • Linux x86_64 fastdebug, tier1 tier2 tier3 tier4, -XX:TieredStopAtLevel=1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315554 needs maintainer approval

Issue

  • JDK-8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/355/head:pull/355
$ git checkout pull/355

Update a local copy of the PR:
$ git checkout pull/355
$ git pull https://git.openjdk.org/jdk21u.git pull/355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 355

View PR using the GUI difftool:
$ git pr show -t 355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/355.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bd477810b176696e0fd043f5594663ebcf9884cf 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86 Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve generated code density. Applies cleanly. Testing passes.

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@shipilev
8315554: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
  • 2545f55: 8317039: Enable specifying the JDK used to run jtreg
  • 321ba68: 8313643: Update HarfBuzz to 8.2.2
  • ffa87b5: 8318240: [AIX] Cleaners.java test failure
  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions
  • cb352c2: 8318759: Add four DigiCert root certificates
  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • ... and 25 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 20, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit 44bb402.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@shipilev Pushed as commit 44bb402.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8315554-c1-testptr-zero branch November 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant