-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316746: Top of lock-stack does not match the unlocked object #361
8316746: Top of lock-stack does not match the unlocked object #361
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request C2 OSR compiled methods are wrong on PPC64 in very rare cases without this fix (wrong unlock order). The fix applies cleanly and has been tested in jdk head and this backport in jdk 21u in our nightly tests. It only changes PPC64 code, removes wrong comments from some other platforms and adds a test which passes on all platforms. |
@TheRealMDoerr |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7588fce.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 7588fce. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of PPC64 fix JDK-8316746. The issue was observed with the new lightweight locking, but the bug is not limited to it. C2 OSR compiled methods may be wrong when the monitor slots were reused in opposite order (see included test).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/361/head:pull/361
$ git checkout pull/361
Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.org/jdk21u.git pull/361/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 361
View PR using the GUI difftool:
$ git pr show -t 361
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/361.diff
Webrev
Link to Webrev Comment