Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318240: [AIX] Cleaners.java test failure #365

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 14, 2023

Hi all,

This pull request contains a backport of JDK-8318240, commit d4b76124 from the openjdk/jdk repository.

The commit being backported was authored by Varada M on 24 Oct 2023 and was reviewed by Matthias Baesken and Andreas Steiner.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318240 needs maintainer approval

Issue

  • JDK-8318240: [AIX] Cleaners.java test failure (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/365/head:pull/365
$ git checkout pull/365

Update a local copy of the PR:
$ git checkout pull/365
$ git pull https://git.openjdk.org/jdk21u.git pull/365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 365

View PR using the GUI difftool:
$ git pr show -t 365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/365.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d4b761242d91aa1bcadc438cce0a9465c0f8b23d 8318240: [AIX] Cleaners.java test failure Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Requesting backport of minor jgss fix for AIX. Tested in SAP nightlies and GHA.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@RealCLanger
8318240: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318240: [AIX] Cleaners.java test failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 16, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

Going to push as commit ffa87b5.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions
  • cb352c2: 8318759: Add four DigiCert root certificates
  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 71eec78: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • fb9bd49: 8317581: [s390x] Multiple test failure with LockingMode=2
  • a25ea4c: 8316719: C2 compilation still fails with "bad AD file"
  • 015dab9: 8316030: Update Libpng to 1.6.40
  • ... and 9 more: https://git.openjdk.org/jdk21u/compare/3515f60e7798bcfe241130e1f46125ad153b1ef8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2023
@openjdk openjdk bot closed this Nov 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@RealCLanger Pushed as commit ffa87b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant