8313402: C1: Incorrect LoadIndexed value numbering

[shipilev]

Clean backport to fix the important C1 bug.

Additional testing:

• New regression test fails without the patch, passes with it
• Linux AArch64 fastdebug tier1 tier2 tier3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313402: C1: Incorrect LoadIndexed value numbering (Bug - P2)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/jdk21u.git pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/37.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313402: C1: Incorrect LoadIndexed value numbering

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 90249f0: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing
• b0da6c1: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"
• 0346a34: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX
• 40092ed: 8313428: GHA: Bump GCC versions for July 2023 updates
• 230df99: 8312591: GCC 6 build failure after JDK-8280982
• 89875df: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (cde5ea3c)

[TobiHartmann]

Looks good.

[shipilev]

Reviews are here, testing is clean, GHA failures are infra issues. Push approval is here.

/integrate

[openjdk]

Going to push as commit fd7a104.
Since your change was applied there have been 27 commits pushed to the master branch:

• 134e270: 8313707: GHA: Bootstrap sysroots with --variant=minbase
• 51d128d: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
• 7350b3f: 8312909: C1 should not inline through interface calls with non-subtype receiver
• 515387d: 8304954: SegmentedCodeCache fails when using large pages
• a21ad55: 8311926: java/lang/ScopedValue/StressStackOverflow.java takes 9mins in tier1
• aafd687: Merge
• bfe037a: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023
• 4273487: 8313593: Generational ZGC: NMT assert when the heap fails to expand
• fd789db: 8312572: JDK 21 RDP2 L10n resource files update
• 46dd733: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
• ... and 17 more: https://git.openjdk.org/jdk21u/compare/53aceba71e19bc2a702d96aa54c3fd0f56e94abf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit fd7a104.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.