Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317039: Enable specifying the JDK used to run jtreg #374

Closed
wants to merge 3 commits into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Nov 16, 2023

This contains the changes of this bug also.
https://bugs.openjdk.org/browse/JDK-8317807

Mach5 testing- https://mach5.us.oracle.com/mdash/jobs/sshivang-jdk21u-20231116-1225-2141342


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317807 needs maintainer approval
  • JDK-8317039 needs maintainer approval

Issues

  • JDK-8317039: Enable specifying the JDK used to run jtreg (Enhancement - P4 - Approved)
  • JDK-8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/374/head:pull/374
$ git checkout pull/374

Update a local copy of the PR:
$ git checkout pull/374
$ git pull https://git.openjdk.org/jdk21u.git pull/374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 374

View PR using the GUI difftool:
$ git pr show -t 374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/374.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2023

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a250ae4d1b9c27757eb12d2f1673187c862149aa 8317039: Enable specifying the JDK used to run jtreg Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 16, 2023
@Shivangi-aa
Copy link
Author

/issue JDK-8317807

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@Shivangi-aa
Adding additional issue to issue list: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039.

@mlbridge
Copy link

mlbridge bot commented Nov 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317039: Enable specifying the JDK used to run jtreg
8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ffa87b5: 8318240: [AIX] Cleaners.java test failure
  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions
  • cb352c2: 8318759: Add four DigiCert root certificates
  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2023
@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@Shivangi-aa
Your change (at version f6384d6) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

As a matter of course, please enable GHA testing and trigger it.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Nov 17, 2023
@erikj79
Copy link
Member

erikj79 commented Nov 17, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@erikj79 The PR has been updated since the change author (@Shivangi-aa) issued the integrate command - the author must perform this command again.

@Shivangi-aa
Copy link
Author

As a matter of course, please enable GHA testing and trigger it.

GHA testing done.

@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@Shivangi-aa
Your change (at version 2342741) is now ready to be sponsored by a Committer.

@erikj79
Copy link
Member

erikj79 commented Nov 17, 2023

/sponsor

@erikj79
Copy link
Member

erikj79 commented Nov 17, 2023

You can create an empty commit using --allow-empty if you need to trigger actions.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

Going to push as commit 2545f55.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 321ba68: 8313643: Update HarfBuzz to 8.2.2
  • ffa87b5: 8318240: [AIX] Cleaners.java test failure
  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions
  • cb352c2: 8318759: Add four DigiCert root certificates
  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2023
@openjdk openjdk bot closed this Nov 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@erikj79 @Shivangi-aa Pushed as commit 2545f55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants