-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317039: Enable specifying the JDK used to run jtreg #374
Conversation
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue JDK-8317807 |
@Shivangi-aa |
Webrevs
|
|
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Shivangi-aa |
As a matter of course, please enable GHA testing and trigger it. |
/sponsor |
@erikj79 The PR has been updated since the change author (@Shivangi-aa) issued the |
GHA testing done. |
/integrate |
@Shivangi-aa |
/sponsor |
You can create an empty commit using |
Going to push as commit 2545f55.
Your commit was automatically rebased without conflicts. |
@erikj79 @Shivangi-aa Pushed as commit 2545f55. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This contains the changes of this bug also.
https://bugs.openjdk.org/browse/JDK-8317807
Mach5 testing- https://mach5.us.oracle.com/mdash/jobs/sshivang-jdk21u-20231116-1225-2141342
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/374/head:pull/374
$ git checkout pull/374
Update a local copy of the PR:
$ git checkout pull/374
$ git pull https://git.openjdk.org/jdk21u.git pull/374/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 374
View PR using the GUI difftool:
$ git pr show -t 374
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/374.diff
Webrev
Link to Webrev Comment