Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319187: Add three eMudhra emSign roots #376

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Nov 17, 2023

Clean backport to JDK 21u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319187 needs maintainer approval

Issue

  • JDK-8319187: Add three eMudhra emSign roots (Enhancement - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/376/head:pull/376
$ git checkout pull/376

Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.org/jdk21u.git pull/376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 376

View PR using the GUI difftool:
$ git pr show -t 376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/376.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19 8319187: Add three eMudhra emSign roots Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2023
@rhalade
Copy link
Member Author

rhalade commented Nov 17, 2023

/approval 8319187 request The fix is to add new root CA certificate. The patch applies cleanly and has good test coverage.

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@rhalade
8319187: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319187: Add three eMudhra emSign roots

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
  • 2545f55: 8317039: Enable specifying the JDK used to run jtreg
  • 321ba68: 8313643: Update HarfBuzz to 8.2.2
  • ffa87b5: 8318240: [AIX] Cleaners.java test failure
  • 44b5b81: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 99d260c: 8313781: Add regression tests for large page logging and user-facing error messages
  • 3c712ed: 8315195: RISC-V: Update hwprobe query for new extensions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 20, 2023
@rhalade
Copy link
Member Author

rhalade commented Nov 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit a9f71e9.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@rhalade Pushed as commit a9f71e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant