Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318957: enhance agentlib:jdwp help output by info about allow option #378

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 17, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318957 needs maintainer approval

Issue

  • JDK-8318957: enhance agentlib:jdwp help output by info about allow option (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/378/head:pull/378
$ git checkout pull/378

Update a local copy of the PR:
$ git checkout pull/378
$ git pull https://git.openjdk.org/jdk21u.git pull/378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 378

View PR using the GUI difftool:
$ git pr show -t 378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/378.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 53bb7cd415f1d2e87d8f06ad5eb611bfdf8ef0ad 8318957: enhance agentlib:jdwp help output by info about allow option Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318957: enhance agentlib:jdwp help output by info about allow option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
  • 2545f55: 8317039: Enable specifying the JDK used to run jtreg
  • 321ba68: 8313643: Update HarfBuzz to 8.2.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 20, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 689b90d.
Since your change was applied there have been 17 commits pushed to the master branch:

  • cf187a1: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
  • 73d59d0: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
  • 53fec1b: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • 177d994: 8306561: Possible out of bounds access in print_pointer_information
  • a9f71e9: 8319187: Add three eMudhra emSign roots
  • 1603958: 8316017: Refactor timeout handler in PassFailJFrame
  • e79ebc7: 8315545: C1: x86 cmove can use short branches
  • 44bb402: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
  • 7588fce: 8316746: Top of lock-stack does not match the unlocked object
  • 1d128dc: 8316025: Use testUI() method of PassFailJFrame.Builder in FileChooserSymLinkTest.java
  • ... and 7 more: https://git.openjdk.org/jdk21u/compare/ffa87b5e3fd896a9562bf43bf2ca237c18ccfadf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@MBaesken Pushed as commit 689b90d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant