8306561: Possible out of bounds access in print_pointer_information

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8306561, commit d6ce62eb from the openjdk/jdk repository.

It also contains a backport of JDK-8319542 inline.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8319542 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8306561 needs maintainer approval

Issues

• JDK-8306561: Possible out of bounds access in print_pointer_information (Bug - P3 - Approved)
• JDK-8319542: Fix boundaries of region to be tested with os::is_readable_range (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/379/head:pull/379
$ git checkout pull/379

Update a local copy of the PR:
$ git checkout pull/379
$ git pull https://git.openjdk.org/jdk21u.git pull/379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 379

View PR using the GUI difftool:
$ git pr show -t 379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/379.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (7af022b1)

[RealCLanger]

/issue add JDK-8319542

[openjdk]

@RealCLanger
Adding additional issue to issue list: 8319542: Fix boundaries of region to be tested with os::is_readable_range.

[RealCLanger]

/approval request Request backport of this nmt fix which fixes crashes observed in GTest on AIX. Testing: SAP nightlies and GHA. Risk is low.

[openjdk]

@RealCLanger
8306561: The approval request has been created successfully.
8319542: The approval request has been created successfully.

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306561: Possible out of bounds access in print_pointer_information
8319542: Fix boundaries of region to be tested with os::is_readable_range

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
• 2545f55: 8317039: Enable specifying the JDK used to run jtreg
• 321ba68: 8313643: Update HarfBuzz to 8.2.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 177d994.
Since your change was applied there have been 13 commits pushed to the master branch:

• a9f71e9: 8319187: Add three eMudhra emSign roots
• 1603958: 8316017: Refactor timeout handler in PassFailJFrame
• e79ebc7: 8315545: C1: x86 cmove can use short branches
• 44bb402: 8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86
• 7588fce: 8316746: Top of lock-stack does not match the unlocked object
• 1d128dc: 8316025: Use testUI() method of PassFailJFrame.Builder in FileChooserSymLinkTest.java
• 3c124e3: 8294156: Allow PassFailJFrame.Builder to create test UI
• 4558e49: 8317834: java/lang/Thread/IsAlive.java timed out
• 3fcc7ea: 8320053: GHA: Cross-compile gtest code
• 8de7b61: 8316003: Update FileChooserSymLinkTest.java to HTML instructions
• ... and 3 more: https://git.openjdk.org/jdk21u/compare/ffa87b5e3fd896a9562bf43bf2ca237c18ccfadf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 177d994.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.