Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306561: Possible out of bounds access in print_pointer_information #379

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 17, 2023

Hi all,

This pull request contains a backport of JDK-8306561, commit d6ce62eb from the openjdk/jdk repository.

It also contains a backport of JDK-8319542 inline.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8319542 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306561 needs maintainer approval

Issues

  • JDK-8306561: Possible out of bounds access in print_pointer_information (Bug - P3 - Approved)
  • JDK-8319542: Fix boundaries of region to be tested with os::is_readable_range (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/379/head:pull/379
$ git checkout pull/379

Update a local copy of the PR:
$ git checkout pull/379
$ git pull https://git.openjdk.org/jdk21u.git pull/379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 379

View PR using the GUI difftool:
$ git pr show -t 379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/379.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6ce62ebc01eb483b486af886d9b79f60ff87de1 8306561: Possible out of bounds access in print_pointer_information Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 17, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/issue add JDK-8319542

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@RealCLanger
Adding additional issue to issue list: 8319542: Fix boundaries of region to be tested with os::is_readable_range.

@RealCLanger
Copy link
Contributor Author

/approval request Request backport of this nmt fix which fixes crashes observed in GTest on AIX. Testing: SAP nightlies and GHA. Risk is low.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@RealCLanger
8306561: The approval request has been created successfully.
8319542: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306561: Possible out of bounds access in print_pointer_information
8319542: Fix boundaries of region to be tested with os::is_readable_range

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6453e64: 8294158: HTML formatting for PassFailJFrame instructions
  • 2545f55: 8317039: Enable specifying the JDK used to run jtreg
  • 321ba68: 8313643: Update HarfBuzz to 8.2.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 20, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 177d994.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@RealCLanger Pushed as commit 177d994.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants