Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320206: Some intrinsics/stubs missing vzeroupper on x86_64 #380

Closed

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Nov 17, 2023


Progress

  • JDK-8320206 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320206: Some intrinsics/stubs missing vzeroupper on x86_64 (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/380/head:pull/380
$ git checkout pull/380

Update a local copy of the PR:
$ git checkout pull/380
$ git pull https://git.openjdk.org/jdk21u.git pull/380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 380

View PR using the GUI difftool:
$ git pr show -t 380

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/380.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b372e28ceb8b054118027626eb454b8a493740b 8320206: Some intrinsics/stubs missing vzeroupper on x86_64 Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @sviswa7 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2023
@sviswa7
Copy link
Author

sviswa7 commented Nov 17, 2023

/approval

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@sviswa7 usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@shipilev
Copy link
Member

/approval

Note the incorrect syntax, so no actual approval request was generated.

@sviswa7
Copy link
Author

sviswa7 commented Nov 27, 2023

/approval request This is a clean backport and not dependent on any other backport.,
A very small patch with changes to emit missing vzeroupper instructions at select locations to avoid AVX->SSE transition penalties.,
Please approve.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@sviswa7
8320206: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 27, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

Please close this PR. OpenJDK 21.0.3 development happens in jdk21u-dev. I.e. this PR needs to move there now.

@openjdk openjdk bot removed the approval label Dec 14, 2023
@sviswa7 sviswa7 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants