Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318562: Computational test more than 2x slower when AVX instructions are used #381

Closed

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Nov 17, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8318562 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318562: Computational test more than 2x slower when AVX instructions are used (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/381/head:pull/381
$ git checkout pull/381

Update a local copy of the PR:
$ git checkout pull/381
$ git pull https://git.openjdk.org/jdk21u.git pull/381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 381

View PR using the GUI difftool:
$ git pr show -t 381

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/381.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0881f2b0c43870ed10b1166d04cef9832e58629e 8318562: Computational test more than 2x slower when AVX instructions are used Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @sviswa7 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Nov 17, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318562: Computational test more than 2x slower when AVX instructions are used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • e7bd0ab: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 21a003a: 8320209: VectorMaskGen clobbers rflags on x86_64
  • 689b90d: 8318957: enhance agentlib:jdwp help output by info about allow option
  • cf187a1: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
  • 73d59d0: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
  • 53fec1b: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • 177d994: 8306561: Possible out of bounds access in print_pointer_information
  • a9f71e9: 8319187: Add three eMudhra emSign roots
  • 1603958: 8316017: Refactor timeout handler in PassFailJFrame
  • e79ebc7: 8315545: C1: x86 cmove can use short branches
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/2545f55e509fdc3a2fa6e4dec33f1b4a20a8b679...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 20, 2023
@sviswa7
Copy link
Author

sviswa7 commented Nov 20, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@sviswa7
Your change (at version 42e5977) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 0941f2c.
Since your change was applied there have been 18 commits pushed to the master branch:

  • e7bd0ab: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 21a003a: 8320209: VectorMaskGen clobbers rflags on x86_64
  • 689b90d: 8318957: enhance agentlib:jdwp help output by info about allow option
  • cf187a1: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return
  • 73d59d0: 8318591: avoid leaks in loadlib_aix.cpp reload_table()
  • 53fec1b: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • 177d994: 8306561: Possible out of bounds access in print_pointer_information
  • a9f71e9: 8319187: Add three eMudhra emSign roots
  • 1603958: 8316017: Refactor timeout handler in PassFailJFrame
  • e79ebc7: 8315545: C1: x86 cmove can use short branches
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/2545f55e509fdc3a2fa6e4dec33f1b4a20a8b679...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@shipilev @sviswa7 Pushed as commit 0941f2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sviswa7
Copy link
Author

sviswa7 commented Nov 21, 2023

Thanks a lot @shipilev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants